Win10PE SE - Contributions to Package Release

Hi all,

started topic to invide You sharing here Your suggestions, hints or corrections (complementary or missing things)
in existing official Win10PESE plugins.

Please do not post here questions or wishes for new features etc. - for this You may open another topic.

It is intended to support another official release of zipped WinPESE package comming soon (perhaps once per half year).
It is intended to provide help with things that are worth including in official plugins for next releases.
It is also intended to decrease time effort the publisher may have with search and collect of valuable info
that maybe were lost from brain but can be found in the large deepness of forum.

@ Lancelot,

I plan to update zip packages ...

If you have other critical things to be updated, let me know.

Yes, I think I have (maybe not exactly critical matters but hopefully usefull for one or the other...).

-------------------------------------------------------------------------------------
Lancelot, Do You think whether it is a good idea to pin current topic on top
near to Bob.Omb's topic "Win10PE SE Release - Extended Support"
for a while and decide later unpin or not (when Bob returns)?
-------------------------------------------------------------------------------------

Some of following remarks may match personally taste/opinion of Mine only.
Anyway. It is up to You to apply them or not.

----------

Sometimes it happens that command lines written into plugins do not execute as intendeded.
Therefore while testing theese plugins I prefer to turn on help in "%BaseDir%\BuilderSE.ini" (via WB gui) - looks like this:

Code: [Select]

[Main]
...
ForceWarning=True
VerboseWarning=True
...

In the past, I've found errors, typos (command not recognized), and extra End commands this way ...
Therefore errors / warnings have been written at the beginning of the log file that would be harder to find anywhere in the text.
Of course don't forget switch back when done.

Btw.: Missing/disabled "Indent Begin / End Blocks" in WB's source editor make it harder to read/follow plugin content.
Why not let it default on ?
And it also would better support an easier comparison (e.g.: via 3rd party software) against content of other plugin which have "Indent ..." on.

I guess this line added in "%BaseDir%\BuilderSE.ini" can do:

Code: [Select]

[Main]
...
SourceIndenting=True
...


+

I recently did a comparison of latest WinPE_SE_2021-03-19.zip with plugin files below My %ProjectDir%
to find changes I made in the past.

Reminding: Source is win10 v.1809 x86 (10.0.17763.1) BuildClass=2
(because verrrrry high build speed like other builders can do is not My main goal)
and testing iso file with VirtualBox

Today I want to start sharing this:


---> See %BaseDir%\Apps\System Tools\Explorer Addons\HashTab_olegpov_v5_vX.Script Version=019 Date=2019.04.12

Code: [Select]

[Main]
...
History019=Lancelot  Update HashTab_v6.0.0.34_Setup for Vista and Later // Update HomePage (Old HomePage: http://implbits.com/hashtab.aspx ) - Date:2019.04.12 // Plugin FileName changed "HashTab_olegpov_v5_vX" - Date:2019.04.12
History_JH002=J.H. 2019-Apr-12 - Hey Lancelot, I added forgotten (?) line "%TheFile%=%TheFile_x86%" to section [Variables_Vista_And_Later] in order to get plugin working with Vista and later too.

[Variables_Vista_And_Later]
...
%TheFile_x86%=HashTab32-6.0.0.34.dll
%TheFile_x64%=HashTab64-6.0.0.34.dll
%TheFile%=%TheFile_x86%

---> See %BaseDir%\Build\1-files.Script Version=168 Date=2020.03.24

Not in x86
Line 1445: InstallCopySys32Mui,vid.dll       --> If,Not,%SourceArch%,Equal,x86,InstallCopySys32Mui,vid.dll
Line 1451: InstallCopySys32Mui,hvhostsvc.dll --> If,Not,%SourceArch%,Equal,x86,InstallCopySys32Mui,hvhostsvc.dll


---> See Your Baby %BaseDir%\Build\Macro_Library.script Version=47 Revision=94 Date=2021.03.12

I don't think We need succes messages during build process and in log file in theese cases I would comment out:

Line 4316: If,%ExitCode%,Equal,1,Echo,"DirCopy successful #2" --> // If,%ExitCode%,Equal,1,Echo,"DirCopy successful #2"
Line 4322: If,ExistFile,%ProjectTemp%\Macro_Library\DirCopy.ini,Run,%ProjectTemp%\Macro_Library\DirCopy.ini,Process --> // If,ExistFile,%ProjectTemp%\Macro_Library\DirCopy.ini,Run,%ProjectTemp%\Macro_Library\DirCopy.ini,Process
Line 4401: Run,%ProjectTemp%\Macro_Library\RegMultiSZ_Log.Script,Process --> // Run,%ProjectTemp%\Macro_Library\RegMultiSZ_Log.Script,Process


---> See %BaseDir%\Components\BitLocker.script Version=023 Date=2019.02.03_11:05.38 (GMT0: -3 Hours)

Code: [Select]

[Main]
...
History022=Lancelot - Add BuildClass 3 support - Date:2018.10.09 // Minor Fix with BuildType - Date:2018.11.23
History_JH001=J.H. 2018-Oct-16 - Win10PESE: Remove "encrypt-bde-elev" (localized means: "Activate BitLocker") ContextMenu entry on Drive ALSO for case when "Lite_CheckBox" is ticked. It appears on bitlocker-capable drive because of true-condition: "...AND System.Volume.BitLockerRequiresAdmin:=System.StructuredQueryType.Boolean#True" in its regkey "AppliesTo"
History023=Lancelot - Add BuildClass - Date:2019.01.14 - Date:2019.01.17 - Date:2019.02.03
...

After line 696 We find

Code: [Select]

If,%Lite_CheckBox%,Equal,False,Begin
...
End

Append this

Code: [Select]

Else,Begin
  // See History_JH001
  If,ExistRegSection,HKLM,Tmp_Software\Classes\Drive\shell\encrypt-bde-elev,RegDelete,HKLM,Tmp_Software\Classes\Drive\shell\encrypt-bde-elev
End


---> See %BaseDir%\Components\Components\Calculator.Script Version=036 Date=2019.01.14

Typo

Code: [Select]

If,%History_CheckBox%,Equal,True,RegWrite,HKLM,0x4,Tmp_Default\Software\Microsoft\Calc,ShowHistory,1
Else,RegWrite,HKLM,0x4,Tmp_Default\Software\Microsoft\Calc,ShowHistory,1

corrected

Code: [Select]

  If,%History_CheckBox%,Equal,True,RegWrite,HKLM,0x4,Tmp_Default\Software\Microsoft\Calc,ShowHistory,1
  Else,RegWrite,HKLM,0x4,Tmp_Default\Software\Microsoft\Calc,ShowHistory,0


Note on the embedded code: I always use my history notes "History_JHxxx" in ascending order under section [Main], each with the date.
 --> xxx starts with 001


To be continued... I hope soon. (Time is the limit. Not the sky.)

We Are One.
Have a nice day. See You.

Hi Lancelot,

If you have other critical things to be updated, let me know.

Yes, I think I have (maybe not exactly critical matters but hopefully usefull for one or the other...).

Critical or not...
Reminding: My source is v.1809 x86

Spend a whole lotta day (almost not quite ):
--> See %BaseDir%\Projects\Win10PESE\Images.script

As You know I'm a fan of BuildClass=2
I have been wondering for a long time: why there are diffrent results on auto-select source index using BuildClass2 or BuildClass3 ? At that time I didn't take a closer look - lack of time. I just made a manual fix.
But recently I took a closer look:

In Section [Interface] see item "WIMImageInfo_Name=..."
BuildClass2 gives: Windows 10 Edu...bla bla N (index 10) ???
BuildClass3 gives: Windows 10 Pro (index 5) --> that's the one We want auto detected, right?

Reason: Fixed-coded commands in section [SetWimTools] from line 417 and below in ascending order of the index numbers:

Code: [Select]

If,ExistFile,%SourceDir%\sources\install_wim\1\Windows\System32\ntdll.dll,Set,%ti%,%SourceDir%\sources\install_wim\1
...
If,ExistFile,%SourceDir%\sources\install_wim\10\Windows\System32\ntdll.dll,Set,%ti%,%SourceDir%\sources\install_wim\10
If,ExistFile,%SourceDir%\sources\install_wim\11\Windows\System32\ntdll.dll,Set,%ti%,%SourceDir%\sources\install_wim\11
If,ExistFile,%SourceDir%\sources\install_wim\12\Windows\System32\ntdll.dll,Set,%ti%,%SourceDir%\sources\install_wim\12
If,ExistFile,%SourceDir%\sources\install_wim\N\Windows\System32\ntdll.dll,Set,%ti%,%SourceDir%\sources\install_wim\N

That is why it always selects the last one available below %Source_Sys% ! --> not good.

So, why not apply once more again great working "wiminfo.exe" by JFX,ChrisR this way:

Code: [Select]

[Main]
...
History_JH001=J.H. 2021-Mar-20 - While using BuildClass=2 ... Remind Me: Provide clarification a bit more.

[SetWimTools]
...
If,%ti%|%tcheck%,Equal,-|-,Set,%tb%,%ti%
//If,%ti%,Equal,-,Set,%tb%,%ti%
End
// ----------------------------------------------------------------------
// See History_JH001
If,Not,ExistDir,%ProjectTemp%\WimInfo,DirMake,%ProjectTemp%\WimInfo
// If You like it shorter:
Call,DirMake,%ProjectTemp%\WimInfo
Run,%ScriptFile%,WimInfoInstall
Set,%ti%,%SourceDir%\sources\install_wim\%WIMIndex%
// ----------------------------------------------------------------------
...

And bingo it works as expected w/o collateral damage. If someone finds something, let me know.


We are one. Have a nice time. See You.

@ Lancelot,

We can have cursor visible at PE startup directly after circling dots not yet existing in PESE,
looks good and is usefull in case We need someday to interact by mouse (e.g.: something with select Yes / No / Cancle / Retry ...)

Look here: http://theoven.org/index.php?topic=2050.msg25838#msg25838 by oxydw
and here: http://theoven.org/index.php?topic=1639.msg39718#msg39718 by Slore

by inserting one more line into (e.g.) "%ProjectDir%\Build\2-Config.script" after line 382 (or where ever You like):

Code: [Select]

[Environment]
...
RegWrite,HKLM,0x4,Tmp_Software\Microsoft\Windows\CurrentVersion\Policies\System,EnableCursorSuppression,0
...

Another nice (IMO) piece could be: See http://theoven.org/index.php?topic=2421.msg39904#msg39904
We can have seconds on the taskbar clock not yet existing in PESE,

by inserting one more line into (e.g.) "%ProjectDir%\Build\2-Config.script" after line 389 (or where ever You like):

Code: [Select]

...
RegWrite,HKLM,0x4,Tmp_Default\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced,ShowSecondsInSystemClock,1
...

+


Reminding only: My source is v.1809 x86 always BuildClass2...


---> See %BaseDir%\Components\Components\CMD Adds.script Version=028 Date=2020.01.14_21:59.25 (GMT0: -3 Hours)

Relevant in case We use BuildClass=3:

Code: [Select]

[Main]
...
History_JH001=J.H. 2020-Jan-18 - I'm sure there is No need for all the other lang  F O L D E R S  with one localized file "msprivs.dll.mui" inside than only this FOLDER "%Target_Sys%\%DistLang%". Hello Lancelot: What about other "*.mui" files than those belonging to "%Target_Sys%\%DistLang%" - and naturally fallback (if any) to en-US locale?

Replaced line 765 (because of ...\??-??\... The exe takes them all - not pretty good

Code: [Select]

[Require_FileList_NT6_System32_ALL]
...
\Windows\System32\??-??\msprivs.dll.mui
...

by

Code: [Select]

[Require_FileList_NT6_System32_ALL]
...
//; See History_JH001
\Windows\System32\en-US\msprivs.dll.mui
//; \Windows\System32\??-??\msprivs.dll.mui
...

---> See %BaseDir%\Components\Components\MsPowerShell.script Version=027 Date=2020.03.20
I have Selected=True

Code: [Select]

[Main]
...
History_JH001=J.H. 2019-Jun-01 - PowerShell in WinPE is verry slow (first start on commandline takes about 20 seconds or so): The CATDB file gets created on the first start of PowerShell.exe, that's why it takes so long. So, to accelerate 1st powershell run I copied folder "X:\Windows\System32\catroot2\{F750E6C3-38EE-11D1-85E5-00C04FC295EE}" (stopped CryptSVC service first) and then used .zip while building an iso. The two files have only about 20 MB. Couldn't find a better solution yet than running WinPE first and grabbing the CATDB file. It is good enough for now :)
History_JH002=J.H. 2019-Jun-03 - Update to History_JH001: It is easier to copy folder "%Source_Sys%\catroot2"
...

Code: [Select]

[Interface]
...
DINI_SM_CM_F_CheckBox=D.ini,1,3,180,60,43,16,True,"__Add Desktop.ini for MultiLanguage Support"
...

Appended to end of setion:

Code: [Select]

[Process_Normal]
...
// See History_JH001 / History_JH002
// If,ExistFile,%ScriptDir%\MsPowerShellCATDB.zip,Begin
//   If,Not,ExistFile,%Target_Sys%\catroot2\{F750E6C3-38EE-11D1-85E5-00C04FC295EE}\catdb,ShellExecute,Hide,%Tools%\7z.exe,"e #$q%ScriptDir%\MsPowerShellCATDB.zip#$q -y -o#$q%Target_Sys%\catroot2\{F750E6C3-38EE-11D1-85E5-00C04FC295EE}#$q"
// End
Shellexecute,Hide,XCOPY.exe,"/K /R /E /I /C /H /D /V /F /Y #$q%Source_Sys%\catroot2#$q #$q%Target_Sys%\catroot2\#$q"
...

---> See %BaseDir%\Components\Components\MSViewer.script Version=020 Date=2019.12.30

Only added to inform interested user:

Code: [Select]

[Main]
...
HistoryNote_JH=J.H. 2014-Mar-22 - NOTE: If running ISO with Vbox We should enable 3D-Support in vbox display settings. Otherwise loaded image may stay blank in Viewer - Anyways slideshow doesn't matter.
...

---> See %BaseDir%\Components\Components\penetwork.script Version=056 Date=2019.02.26_00:25.39 (GMT0: -3 Hours)

Added two history lines after:

Code: [Select]

[Main]
...
History054=Lancelot update to 0.59.Beta8 Holger Reply 65 http://TheOven.org/index.php?topic=247.msg25430#msg25430 (Thanks to bob.omb and teik support) - Date:2017.12.31 - Date:2018.01.04
...

This ones:

Code: [Select]

[Main]
...
History_JH001=J.H. 2018-Jan-14 - Reg values both "MinimizeToTray" and "ShowTrayActivity" corrected REG_DWORD (not REG_SZ)
History_JH002=J.H. 2018-Jan-14 - Reg value "CloseToTray" is located in "Tmp_Default\Software\PENetwork" (not "Tmp_Software\PENetwork") and corrected REG_DWORD (not REG_SZ)
...

[PENetwork-Registry]
...
// See History_JH001
If,%ShowTrayActivity_CheckBox%,Equal,True,RegWrite,HKLM,0x4,Tmp_Default\Software\PENetwork,ShowTrayActivity,1
Else,RegWrite,HKLM,0x4,Tmp_Default\Software\PENetwork,ShowTrayActivity,0
...
// See History_JH001
If,%MinToTray_CheckBox%,Equal,True,RegWrite,HKLM,0x4,Tmp_Default\Software\PENetwork,MinimizeToTray,1
Else,RegWrite,HKLM,0x4,Tmp_Default\Software\PENetwork,MinimizeToTray,0
// See History_JH002
If,%CloseToTray_CheckBox%,Equal,True,RegWrite,HKLM,0x4,Tmp_Default\Software\PENetwork,CloseToTray,1
Else,RegWrite,HKLM,0x4,Tmp_Default\Software\PENetwork,CloseToTray,0
...

---> See %BaseDir%\Components\Components\PPPoE.script Version=015 Date=2019.02.01

Default is Selected=False
Test results in 2019 while Selected=True

Code: [Select]

[Main]
...
History_JH001=J.H. 2019-Jun-25 - Dll files not in v1809
History_JH002=J.H. 2019-Jun-26 - Plugin disabled: Tested in VirtualBox v6.0.4.128413 --> It leads to dramatically increase of PE boottime; Welcome screen stays about 60 seconds (about 10 secs w/o it); PEnetwork, Pintool don't start; ...

Changed lines 325 + 355 (only BuildClass=2 is interested):

Code: [Select]

...
Require_FileQ,atmfd.dll
...
Require_FileQ,gacinstall.dll
...

to:

Code: [Select]

...
// See History_JH001
If,ExistFile,%Source_Sys%\atmfd.dll,Require_FileQ,atmfd.dll
...
// See History_JH001
If,ExistFile,%Source_Sys%\gacinstall.dll,Require_FileQ,gacinstall.dll
...

while BuildClass=3 doesn't care about missing files.

More to come... I hope 

See You.

Thanks HeyJoe,

Keep them coming.

I will response and update all when I get back home (hopefully max 1 week)

Hi HeyJoe,

Slowly catching you outside home :
*

-------------------------------------------------------------------------------------
Lancelot, Do You think whether it is a good idea to pin current topic on top
near to Bob.Omb's topic "Win10PE SE Release - Extended Support"
for a while and decide later unpin or not (when Bob returns)?
-------------------------------------------------------------------------------------

Done, now topic is Sticky 


*

Btw.: Missing/disabled "Indent Begin / End Blocks" in WB's source editor make it harder to read/follow plugin content.
Why not let it default on ?
And it also would better support an easier comparison (e.g.: via 3rd party software) against content of other plugin which have "Indent ..." on.

I guess this line added in "%BaseDir%\BuilderSE.ini" can do:

Code: [Select]

[Main]
...
SourceIndenting=True
...

SourceIndenting is default True when you first run wb, still, When I get back home I will also add to .ini as you wish since nothing changes. 

+
keep in mind: It will only help you to figure out missing "End", It will not help you to figure out extra (forgotten end).


*
Very good users like you figure out goals of warning,
but for regular users warning means there is something to fix,
 and you know with your settings there are always big set of warnings most of them useless,
  which cause regular user feedback with topics saying "I get warning ....."

There are simple solutions but developers were deaf (looong story) so we avoid such topics by disabling them.
Deafness is big trouble for developers. 

+
As far as I remember verbose and/or ForceWarning continue building even when there is a failure which build should stop but because of these settings not stop....
I can not remember the condition. (10 years or more ago) Let me know with a test plugin if you can ?
Since plugins are well written without such failure reports, it is hard to remember now ...

*
About : ForceWarning + VerboseWarning

+
wb has no check for begin-end even with : ForceWarning and VerboseWarning
as you wrote previously it is easy to catch missing end with editor
extra end gives "Stack is empty" error with or without ForceWarning and VerboseWarning
with other words : ForceWarning and VerboseWarning have no advantage to catch begin-end related bugs.

+
I try to document warnings with v082.0.0.15:

Default Warnings:
Unrecognized command:
Exit
Echo - Warn

ForceWarning :
Set - You cannot set WinBuilder system variables PERMANENT:
Reference to undefined variable:
Invalid parameter count:
RegWrite - Overwrote existing key

ForceWarning + Verbose:
Script has no certification!
FileDelete - Sucessfully deleted
+
Build (BigBluePlay) continues even there is a failure (more info (eg. test plugin) required.)




Let me improve documentation, these are things I can find and remember with a quick test.

memo:
1) Invalid parameter count: is most useful but it also fails at some conditions (writing from memo) so the developer decided to hide failure by not adding to Default Warnings: . 
2) Reference to undefined variable: mostly useless rarely useful ... since we had to update all plugins to avoid this warning, when seen on a plugin it is mostly workarounded again and became rare useful. Since mostly useless and cause a lot of annoying warnings on well-written projects (>10 years ago) developer decide not to add to Default Warnings.

Shortly: Yes I agree these wrong named "warnings" are useful for developers like you, but not good for the regular user and not good for project admin on distribution.

ps: I just edit your initial post by replacing some [code --> [codebox to avoid widescreen bug of forum engine.
When you click forum editor button # that is the reason It will give you codebox 


Slowly slowly ...


Edit: Figured out later and Strikethrough things not related to ForceWarning + Verbose

Hi Lancelot,

To make it short:

Slowly catching you outside home :

Please don't overdo it. Stay healthy.

Done, now topic is Sticky

Thx

SourceIndenting is default True...

If that is the case, then I have been wondering for a long time why plugins that I have downloaded from server in the past
- You worked on almost all of them - are saved without "SourceIndenting" ?

About : ForceWarning + VerboseWarning ...

I know almost the whole story about it. (Also a lot from the distant past.)
I was just trying to give the newbies among the developers an idea that they might not be familiar with.
In order to avoid annoying topic like this

  ...cause regular user feedback with topics saying "I get warning ....."

it is of course good to let it off.
I totally agree.

... avoid widescreen ...
[code vs. [codebox --> thx for tip.

Back to contribution works.
Will continue with edit reply#1 shortly -->  http://theoven.org/index.php?topic=3351.msg39955#msg39955

See You.

If that is the case, then I have been wondering for a long time why plugins that I have downloaded from server in the past
- You worked on almost all of them - are saved without "SourceIndenting" ?

Shortly: Because of winbuilder internal wrong design. 

1) There is no command to add "SourceIndenting" to a plugin
2) Ini* commands remove "SourceIndenting" (and other things) -> which cause trouble ....

Upload Steps: IniWrirte.....Version,..    IniWrite,....,Date,.. ..... --> "SourceIndenting" gone ... no command to add "SourceIndenting"  ---> upload to server.

Since the majority use internal editor, so far no problem.

*
Additional info:
Try SynWrite
http://theoven.org/index.php?topic=3155.0
SynWrite Plugin has "Plugin Lexer" originally written by Nikzzzz and some updates by me.
I use SynWrite as the external editor at home for plugins, but I did not add SourceIndenting yet, maybe you are interested. 

@ Lancelot,
Let it be good. You shouldn't change or expand anything that you don't like. Both we know: Time is the limit. N...

The only thing I'm interested in is that plugins are stored on server in such a way that they contain "Indent Begin / End blocks".
This is: being able comparing them (using 3rd party tool) exactly byte per byte against previous version I modified to My Needs.
Nothing more nothing less.

Regards

Hi HeyJoe

*

Let it be good. You shouldn't change anything that you don't like.

In this case, since I do not have a ready syntax like "Call,AddPluginIndent" there is nothing I can quickly do.

I agree with you, It would be nicer on the server with indent. 

*
Today I check your feedbacks in offline mode (thanks to slore on the creation of proxy plugin which leaded to bonus offline mode)
%99 all done 
Thanks a lot. 

I update the following plugins with your feedback + other things I notice during tests. (on server when I get back home)

Win10PESE\Build\"1 - Copy Files"
Win10PESE\Build\"Macro Library (ML)"
Win10PESE\Components\"BitLocker"
Win10PESE\Components\"Calculator"
Win10PESE\Components\"Internet Explorer 11"
Win10PESE\Tweaks\"Wallpaper"
Win10PESE\Apps\Network\"QtWeb"
Win10PESE\Apps\System Tools\Explorer Addons\"HashTab v5 v6 (olegpov)"
Win10PESE\Apps\System Tools\Windows Setup\"WinNTSetup3"
Win10PESE\Finals\"PostConfig"
Win10PESE\Finals\"Create ISO"
Win10PESE\Utils\"Utils Tools 001"

I will do some more updates which I believe will ease your forcewarning-verbose builds.

only 2 things:
1)

Line 4316: If,%ExitCode%,Equal,1,Echo,"DirCopy successful #2" --> // If,%ExitCode%,Equal,1,Echo,"DirCopy successful #2"
Line 4322: If,ExistFile,%ProjectTemp%\Macro_Library\DirCopy.ini,Run,%ProjectTemp%\Macro_Library\DirCopy.ini,Process --> // If,ExistFile,%ProjectTemp%\Macro_Library\DirCopy.ini,Run,%ProjectTemp%\Macro_Library\DirCopy.ini,Process
Line 4401: Run,%ProjectTemp%\Macro_Library\RegMultiSZ_Log.Script,Process --> // Run,%ProjectTemp%\Macro_Library\RegMultiSZ_Log.Script,Process

Line 4316: Done 
Line 4322: I did not test, but as far as I can remember it should be running to give more info with echo
Line 4401: as far as I remember this only echo RegMultiSZ result. (and with RegMultiSZ it is frequently critical)

2)
Images Configuration

In Section [Interface] see item "WIMImageInfo_Name=..."
BuildClass2 gives: Windows 10 Edu...bla bla N (index 10) ???
BuildClass3 gives: Windows 10 Pro (index 5) --> that's the one We want auto detected, right?

Yes right. 

Following your code fixes I understand what you do but ....

Here I have Windows 10 Pro index 6 so our sources should be different.

I hope you download your source from TechBenc, let me know which sources you have, and I can reproduce here your results. 
On this case, the Best way is to have the same results with the same source 

ps: When I get back home, I will download a Turkish 1809 x64 source anyway one more iso no problem to me.   


Keep them coming
See You

Hi Lancelot,

Upload Steps: IniWrirte.....Version,..    IniWrite,....,Date,.. ..... --> "SourceIndenting" gone ...

Yes I know, "IniWrirte,..." commands kill indenting. It's a pity.
That's why I sometimes apply "TxtReplace,..." but with caution: it's tricky, because it replaces all it finds.
It has no in-build parameter "Section".

Here I have Windows 10 Pro index 6 so our sources should be different.

Index 6 I think is Windows 10 Pro N not Windows 10 Pro

I hope you download your source from TechBenc,

Yes I did. See pic "TechBench.png"

See You.

Hi HeyJoe,

Yes I know, "IniWrirte,..." commands kill indenting. It's a pity.
That's why I sometimes apply "TxtReplace,..." but with caution: it's tricky, because it replaces all it finds.
It has no in-build parameter "Section".

That's why I sometimes apply "TxtReplace,..." but with caution: it's tricky, because it replaces all it finds.
It has no in-build parameter "Section".

All "Ini* pitty" workarounds also have some disadvantages...
TxtReplace -> I also use knowing tricky ... --> but it is fast
Call,IniWrite --> works nice and avoids tricky --> but slow (I have plans to write a faster macro in future)
ini...exe tools --> fast but requires a set of codes to prepare, so only good if you have lots of special iniwrite case

To be able comparing them byte per byte against previous version outside WB and w/o changing anything first.

I wish you wrote your goal at very first. 
You made me discover and work on unrelated things I did not work on before. But results very useful to me.   
If one day you write a tool to add indent, I can create "Call,AddPluginIndent" and upload the plugins to servers that way.
I am sure you are familiar with tools we use inside Macro Library.

Inside compare button works fine, I use compare button before I upload to the servers or to see the changes I made during development.
 (since it also supports offline mode If I have my laptop with me with some free time I can continue working on things)
Initially, I created compare button to see the changes uploaded by other admin. 

ps: It is hard to catch edits on replies. Feel free to reply to topics.

Index 6 I think is Windows 10 Pro N not Windows 10 Pro

No N only Pro .......   

Yes I did. See pic "TechBench.png"

Perfect 
I have the exact same source in my archive. (Probably from last year tests with CD-RW (Kare))

I will post when I find the time (Tomorrow) to test. 


See You.

Hi Lancelot,

No N only Pro .......

Have a look at what "wiminfo.exe" told Me.

See You.


Edit: Uh oh, just remembered that while analyzing build log from french coelhosauro, http://theoven.org/index.php?topic=3325.msg39842#msg39842
I also saw Index 6. Same as You posted.
So that seems OK.

It is enterprise according to d/l ISO. But we consider it PRO.
Apparently M$ does something during the real setup (license activities in registry or so ?) that leads to:
 - Real OS has Pro - according to Your license key --> OK.
 - At PE runtime We have Enterprise. So what. Also good. @ M$: We are happy.
--> both readable according to registry key(s) responsible for that.

Btw.: N means No Media Player ... , isn't it ? So what. Some don't care.

Take it easy.

Hi HeyJoe,

Yes index 5 with Win10_1809_German_x32.iso
As you already figure out
 BuildClass3 get ProductName info from wim file
 BuildClass2 get ProductName info from registry
  and with Win10_1809_German_x32.iso ProductName info (index 5) mismatch.

I believe BuildClass2 should follow the registry following its install.wim independent nature.
So I leave it as it is since the index is auto-detect correct with 5 which is the important part. 

Let's see that a bonus feature to catch when there is such a case.   

I add History Notes about that.   

*
Enterprise - Pro : I guess only licensing change the features to be active or not.?!?!?!

*
N means No Media Player  --> at early XP times It was "No Media Player" later better say "No Media Player and Related"
NK means No Media Player  and Messenger:  --> at early XP times . Later better say "No Media Player and Related Media Stuff" + "No Messenger and Related"
ps: As far as I can remember, some Media Player-related files also missing at System32 ...

*
Macro Library:
Line 4322:
Line 4401:
I find time to test.
Mid way: I use // instead of Echo. so no success Echo on process ui, info still available at log. 

*
Now I catch you 

Keep them coming. 

Hi Lancelot,

Mid way: ... info still available at log.

Maybe not very related to current topic,
but recently I stumbled across the annoying message "Out Of System Resources" during build again.
I remember that this was often asked and described in the forum - including answers/opinions. E.g. here: http://theoven.org/index.php?topic=1502.msg17551#msg17551 and here: ... and here: ...

I believe (can't remember where read in web) that the main reason has to do with the capabilities of our respective graphics cards / drivers.
One more the other less. WB is most likely not guilty of this particular case.

I'm sure We can definitely do something about this annoyance if We concider in plugins the following:
 1.: If there is a logo *.ico installed by the author remove it. --> Not good. Default logo pic looks ugly a bit in WG's gui.
 We can better:
 2.: Replaced it with different image format - preferably *.jpg.

In the past I did replacing them step by step on "particularly annoying" plugins.
Result: pop-up never came up again --> at least from plugin treated this way

I belive if this were the case in all (PESE-official) plugins to be processed, you could go away to have a coffee (or better a beer if you like).
If you come back after a beer or two (coffee) the build is done, provided that all plugins are otherwise error-free.

OK, some say: *.ico looks better than *.jpg. Yes !? --> So what.

Back to contribution works.

+

ps:

ps: It is hard to catch edits on replies. Feel free to reply to topics.

I know there is no notification on edits send to E-mail acounts.
That's a good thing. It would generate a lot more traffic unnecessarily.
I just want to complete reserved reply #2 shortly -->  http://theoven.org/index.php?topic=3351.msg39956#msg39956
Then continue reply to topics.

Hope you are fine.
See You.

Hi HeyJoe,

*
Don't blame .ico so quickly, change .ico on related plugins to another .ico you will see again fixed. 

Let me know the name of plugins you change 

"Out Of System Resources" also popup other places ... but most annoying naturally during build.

I understand how winbuilder bad programming intersects with windows-viewer + windows-cache ... long story .....

On Gena and Azin we already workaround that by using "Workaround Bugs" plugin, no "Out Of System Resources" bug report from these projects. 

Personally, I install WinBuilder_BugWorkaround.exe (open source) to my startup so I do not notice "Out Of System Resources" since ... > 10 years and more I guess.
 (even at winbuilder had active development at that times, these and other bugs ignored, since developers focus on some bad development... all failed at last as I had predicted years ago  ....)

Code: [Select]

Call,DownloadX,"%BaseDir%\Projects\Yomi\UtilsY\Workaround_Bugs.script"
Call,Restart

See: Downloading Plugins with a CodeBox

on Utils\"Workaround Bugs" Plugin :
Either
1) Click "WinBuilder BugWorkaround" button when you start using builder
Or
2) Click "Install Startup" button for the days you work with builder and later when you finish PE related things "UnInstall Startup" button available.

Well, you have the overall solution at hand without modifying plugins and waiting for the next "Out Of System Resources" on another one. 

*

I know there is no notification on edits send to E-mail acounts.

Thanks for the understanding. 
Also edits unnotified when checking "Active Topics"

That's a good thing. It would generate a lot more traffic unnecessarily.

Then continue reply to topics.

Let the traffic flow. 

Feel full free to post even for simple typos or other things. I made many uploads in the past even for a single Description typo
 since uploading server is very easy on my side and I believe good things should look good (hobby perfection). 

I just want to complete reserved reply #2 shortly -->  http://theoven.org/index.php?topic=3351.msg39956#msg39956
Then continue reply to topics.

 

ps: If can not find a reliable wifi connection, I will try to upload new plugins to servers with my phone (tethering) till the weekend.

Hi Lancelot,

In short:

Don't blame .ico so quickly, ...

That is not my intention. I just want to say that a smaller compression factor of the logo image is easier to process by WB and respective graphic equipment.

+
It is a matter of opinion whether or not to use mentioned workaround. I do not.
Because when "Out Of System Resources" occurs, I want to know where it is coming from to decide Myself: is it serious or not ?

"Out Of System Resources" also popup other places ...

During build I have never had this type of "Out Of System Resources" of plugins treated as decribed - either no author-encoded logo image or none-.ico-image author-encoded logo.

Edit: Other reason of stupid "Out Of System Resources" than mentioned during regular build ?
Can't remember. I'm pretty sure, answer is no.

Let me know the name of plugins you change

All own developments except a few PESE-official ones I guess. It is loooong time ago. However, I won't find it in a hurry. Hope tomorrow or so.
(.ico image extracted from plugin, converted to .jpg and re-integrated into plugin.)

ps: If can not find a reliable wifi connection,...

No rush ! The world can wait.

See You.

Hi Lancelot,

Addendum:

I understand how winbuilder bad programming intersects with windows-viewer + windows-cache ... long story .....

Oh, You are sure that this has mucho to do with the way the .ico was transferred by WB to the graphics?
I see.

OK WB: You are at least partially guilty

So it makes all the more sense, also in Our own interest to help the WB, not to fail if We believe We can see the reason for this particular weak point.
W/o thinking about it any further.


Regards.

Hi HeyJoe,

OK WB: You are at least partially guilty

Full guilty from my eyes. 
 
Bad programming on this area was reported years and years ago even at wb 076 times ... (probably even before I start to use wb)

+
My interest is only to have help Project run smooth. I hope one day we can get rid of wb.

+

During build I have never had this type of "Out Of System Resources" of plugins

I also never had this type of "Out Of System Resources" during build for years now,
 and I do not have a fast laptop at all (no ssd etc.) so from my experience all .ico .jpg .bmp logos are fine.
   Only see replies on topics "during build....." and we already have a workaround solution at hand for such users.

*

ps: If can not find a reliable wifi connection,...

No rush ! The world can wait.

I can not connect to server with tethering. I guess I am in slore position now. The world will wait more. 

*
I remember trouble with ForceWarning
eg.

Code: [Select]

Call,DirDeleteMake,%ProjectTemp%\Test
FileCreateBlank,%ProjectTemp%\Test\Dummy.ini
DirMake,%ProjectTemp%\Test\Dummy.ini
Echo,"You Should not see this message",Warn

Normally (without ForceWarning) you do not go to next line (echo .. warn) if there is failure.

It is a simple code example, on a long code it can cause big trouble and frequently make it harder to figure out error since most end users report last error on the list and there were lots of error after initial error ...

At least projects and many plugins designed that way ...
 Years ago I disagree and report troubles to wb developers which were ignored, and made many updates on plugins at critical areas to prevent "next line" failure + update following many plugins following end-user posts + update design of new plugins with existing ones. (lots of beers  )
   With lots of wb workaround time on plugins, you do not face bad errors when you test.
     Code writing would be easier and I would be 15 kg lighter  if there were no such option that goes next line after failure.

ps: Azin has internal check about this setting and do not allow build further for a regular user.
 Nothing complex for an Advanced user like you who can easily disable such check.
  On my side, I do not want to spend time on bug reports on topics related to this setting and life is easier when writing project plugins.

Shortly: Be more careful when developing plugins or checking a failure with this option enabled. If a complex failure test also after disabled. 

*
I did not notice new edit on your replies, just put a "heads up" kind reply after you edit. 

See You

Hi HeyJoe,

I find a reliable wi-fi connection, and happily press the upload button on plugins one by one while drinking coffee. 

Following Plugins updated on all projects, most updates relevant to current topic :

\"Images Configuration" Plugin
\Build\"1 - Copy Files" Plugin
\Build\"Chief PluginCache" Plugin
\Build\"Themes" Plugin
\Build\"Macro Library (ML)" Plugin
\Shell\"0 - Shell Loader" Plugin
\Shell\"1 - Explorer Shell" Plugin
\Components\"Wallpaper" Plugin
\Components\"BitLocker" Plugin
\Components\"Calculator" Plugin
\Components\"HwPnp" Plugin
\Components\"Internet Explorer 11" Plugin
\Components\"MMC" Plugin
\Components\"VSFilter / DirectVobSub - XySubFilter" Plugin
\ComponentsY\"NotePad" Plugin
\Apps\File Tasks\"Q-Dir Nenad" Plugin
\Apps\Network\"QtWeb" Plugin
\Apps\System Tools\Explorer Addons\"HashTab v5 v6 (olegpov)" Plugin
\Apps\System Tools\"LetterSwap" Plugin
\Apps\System Tools\Windows Setup\"WinNTSetup3" Plugin
\Finals\"PostConfig" Plugin
\Finals\"Create ISO" Plugin
\Utils\"Utils Tools 001" Plugin

ps:
\Tweaks\"Wallpaper" Plugin Moved and updated to \Components\"Wallpaper"

*
I am waiting for the next. 

Hi Lancelot,

I read tons (almost really ) of Your posts from the past - Many of them at a time when it was still possible to read the forum without an account.
I understand your anger about deafness of (some) developers...
Please stay healthy.

Code: [Select]

...
Echo,"You Should not see this message",Warn

Would like to change/add (sarcasm  ):

Code: [Select]

Echo,"You will NOT see My echo. There is a fatal error, but My developer is not of the opinion that the build should be aborted. I think it's fool's own fault - not Mine - if he's turning on the poorly developed options.",NOWARN

... If a complex failure test also after disabled.

Yes, I always do. Don't worry.


Hopefully I didn't put an overload on You.
This is a "heads up" You required:
See edited reply #2 http://theoven.org/index.php?topic=3351.msg39956#msg39956

See You.