Encode error

System.OutOfMemoryException error while encode.
The 7z files  67MB (200MB decompressed) seems to be too large.
Is there a max. file size?

Code: [Select]

<Errors>
- [1] Error in Script [Encode files.7z] (Win7PESE\0scars\Apps\Supplementary\MultiMedia\SMplayerPortable\7z\files7z.script)
[Error] Encode - Exception of type 'System.OutOfMemoryException' was thrown. (Encode,%ScriptDir%\%ScriptNew%,carpeta,%ScriptDir%\%SetupFilex86%) (Line 26)

Thanks for reporting, Oscar, I notified the developer on GitHub.

how much RAM does your computer have and are you running a x32 or x64 OS?

I've tested with files up to 800MB in size with no issues, but I have a pretty beefy rig.

0scar, does your system have low memory?

PEBakery roughly takes three steps when encoding files:
1. Compress file into ZLibStream (Similar to zip compress)
2. Encode ZLibStream into base64 string
3. Split base64 string into fit in .script multiline format (WBZip)

Let's say a file's size is n Byte. Each step requires a buffer able to hold specific size.
Step1 : n or less (since it is compressed)
Step2 : 3n (Base64 have a overhead of 33% and .Net stores string in UTF16, doubling the size. 1.33n * 2 => 2.7n)
Step3 : 3n (Same with step2)

So in theory, PEBakery requires roughly memory 7 times of file size.
I always wanted to optimize this, but handling WBZip format is tricky and was delayed since other features had more priority.

My computer has 4GB 

Task manager memory numbers (W7, 32bits):
Total 3300
Cached 1700
Available 2600
Free  +-600 (this is the problem, it goes to cero fast when the plugin runs )

With w10 the memory numbers are different, there is no Free section and it is not easy to see what part goes wrong.

I have found another issue with Encode.
Encode does not work with scripts (Unable to load script error) located in folders above the folder PEBakery is, but it can load the script fine if it is in any folder under the folder PEBakery is.

Code: [Select]

<Errors>
- [1] Error in Script [Encode test file.7z] (Win8.1SE\0scars\Utils\oscar packed\files7.script)
[Error] Encode - Unable to load script [E:\test\\new.script] (Encode,%FileBox2%\%ScriptName%,Folder,%FileBox2%\%SetupFilex86%) (Line 97)

I am optimizing memory requirement of Encode/Decode command.

Code: [Select]

Encode does not work with scripts (Unable to load script error) located in folders above the folder PEBakery is, but it can load the script fine if it is in any folder under the folder PEBakery is.
PEBakery only accepts .script file under %BaseDir% in Run/Exec command, it seems that limitation also applied into Encode/Decode without notice.

I have optimized Encode command's memory usage, please try lastest nightly build.

All old issues solved, no problem with 7z file size when encoding  and Pencil edits files or opens all folders fine. 
But there is a new issue:

Code: [Select]

<Errors>
- [1] Error in Script [SMplayer 7z] (Win10PESE\MyPlugins_Direct\0scars\Apps\Supplementary\MultiMedia\SMplayerPortable\SMplayer.script)
[Error] ExtractFile - Invalid length for a Base-64 char array or string. (ExtractFile,%ScriptFile%,Folder,%SetupFile%,%TargetDir%\Program Files\%ProgramFolder%) (Line 38)

Request:
May I suggest you to change the Pencil tootip to Edit Script or Open Folder?
Though I think a new dedicated button Open Script Folder  might be better.

Can you upload a file SMPlayer.7z so I can investigate the issue?

Request:
May I suggest you to change the Pencil tootip to Edit Script or Open Folder?
Though I think a new dedicated button Open Script Folder  might be better.

I changed small buttons' behavior when a folder is selected. Please download lastest version again and test.

SMplayerplugin7z:
https://www.dropbox.com/s/xv4uh6aaeyrxdj8/SMplayerplugin7z?dl=0

I found a line 4096 of attachment is missing:

Strange enough, it gets properly extracted with WinBuilder.

EDIT
Line 8196 and 12288 is empty too, I guess it is done by purpose.

When I encode this file in WB082, there are no empty lines in attachment.
Which version of WinBuilder was used to create this .script file?

it gets properly extracted with PEBakery  Beta3 too
The script was created with  your last nightly build
I have created it with my own tool but if created with Pc Packed it has the same error.

Then it should be a regression caused by recent optimization.

This issue only appears if a compressed file is larget than about 16MB.
Please re-encode the file and try extracting with new nightly build. It should have fixed the issue.
It also improved error checking in ExtractFile, so it should log "Encoded lines are malformed" error in corrupted script (one created with last nightly bulid)

Success   



But now...

Code: [Select]

<Errors>
- [1] Error in Script [9 - Autorun] (Win10PESE\Build\9-Autorun.script)
[Error] ExtractAllFiles - Encoded lines are malformed (ExtractAllFiles,%ScriptFile%,%SourceArch%,%Target_Sys%) (Line 51)

Strange enough, encoded files of '9-Autorun.script' have 1024 chars per line (opposed to 4090 chars of others).
I tried to fix this, test agian with lastest nightly build.

Solved! 

Code: [Select]

Encode does not work with scripts (Unable to load script error) located in folders above the folder PEBakery is, but it can load the script fine if it is in any folder under the folder PEBakery is.
PEBakery only accepts .script file under %BaseDir% in Run/Exec command, it seems that limitation also applied into Encode/Decode without notice.

ExtractAllFiles has the same limitation:

Code: [Select]

<Errors>
- [1] Error in Script [Extract From Scripts] (Win10PESE\MyPlugins_Direct\0scars\Utils\oscar packed\extract.script)
[Error] ExtractAllFiles - Unable to load script [E:\Win81PE\Projects\Win8.1SE\Apps\HD Tasks\MBR\BootIce.script] (ExtractAllFiles,%FileBox3%,Folder,%FileBox2%) (Line 26)