My Computer - Name Plugin

Hi bob.omb

Just reporting an error I find with this plugin using fully updated Win10PE SE/1809 and ver 9 of that plugin

If I leave it on the default option setting of

Old 'Computer' name Localized String

you get an incorrect icon name on the desktop (a dll ref), If I use a custom name it's correct, (not a prob to me as I always use custom)
please see attached pic

Where is My Computer - Name Plugin?  Which plugin are you referring to    all standard included SE plugins are set to default on my side without reproducing error.

I do not know the servers as well as Lancelot, you will have to be a little more specific when asking me 

AppsY>??

AppsGS>??

 
  Found it..

What is the Old 'Computer" name Localized string supposed to look like?  It is easy to change this value for the latest versions of Windows only leaving the orginal function intact for older versions using Call,Compare.

Also is it only the name that is the issue? The link works correctly right?

Hi

What is the Old 'Computer" name Localized string supposed to look like?

I can't remember I've always changed it with custom - maybe 'MyComputer'

Yes, the link works fine

Sorry I just assumed you'd know of it as it was only updated very recently - last month ish

Hi bob.omb

Where is My Computer - Name Plugin? 

Edit: Already exists at Win10PESE\Tweaks\My Computer - Name

If required also exists on yomi:
Call,DownloadX,"%BaseDir%\Projects\Yomi\ComponentsY\Tweaks Explorer\Exp MyComputer_Name.script"
http://theoven.org/index.php?topic=2672.0

What is the Old 'Computer" name Localized string supposed to look like? 

having a quick look to history will get you the answer:
History002=Chris old Computer Name (on Win8 to change  "This PC" to "Computer" ) Reply 13 http://TheOven.org/index.php?topic=851.msg10894#msg10894 - 2014.01.30

"Old 'Computer' name Localized String" is the 3rd option (If,%pRadioGroup1%,Equal,2,)
It seems Win10 "Computer" not exists at ,-33010 on Win10

check shell32.dll with Resource Hacker to find Computer

after finding see ... on following codobox:

Code: [Select]

[Process_Main]
Call,TargetVersion,,4x
...
//-
If,%pRadioGroup1%,Equal,2,Begin
  If,%OSFamily%,Equal,NT5,Begin
    If,%NoWarnROW%,Equal,True,System,ERROROFF,2
    RegWrite,HKLM,0x2,Tmp_Software\Classes\CLSID\{20D04FE0-3AEA-1069-A2D8-08002B30309D},LocalizedString,"@#$pSystemRoot#$p\system32\shell32.dll,-9216"
    RegWrite,HKLM,0x2,Tmp_Default\Software\Microsoft\Windows\CurrentVersion\Explorer\CLSID\{20D04FE0-3AEA-1069-A2D8-08002B30309D},,"@#$pSystemRoot#$p\system32\shell32.dll,-9216"
  End
  Else,Begin
    If,%TargetVersion1%,Bigger,9,Begin
      If,%NoWarnROW%,Equal,True,System,ERROROFF,2
      ...
    End
    Else,Begin
      If,%NoWarnROW%,Equal,True,System,ERROROFF,2
      RegWrite,HKLM,0x2,Tmp_Software\Classes\CLSID\{20D04FE0-3AEA-1069-A2D8-08002B30309D},LocalizedString,"@#$pSystemRoot#$p\system32\shell32.dll,-33010"
      RegWrite,HKLM,0x2,Tmp_Default\Software\Microsoft\Windows\CurrentVersion\Explorer\CLSID\{20D04FE0-3AEA-1069-A2D8-08002B30309D},,"@#$pSystemRoot#$p\system32\shell32.dll,-33010"
    End
  End
End
//-

Edit:
fixed my mistake, plugin already exists at Win10PESE

Sorry I just assumed you'd know of it as it was only updated very recently - last month ish

only added history notes, plugin is same:
History009=Lancelot Added HistoryNotes about troubles with changing ComputerName.... - Date:2018.11.01

@Lancelot :
Most icons used for special folders (ThisPC icon for instance) are taken from imageres.dll instead of shell32.dll even if some of them are present into both.

Thanks RXTech

Can you tell me string id of Computer at imageres.dll with resource hacker.
So we can quickly support initial Chris Design

Ps:
I mostly away from home pc these days and too many new things around.
I mostly feedback with mobile phone.
Any help that will gain time appreciated.

Hi,
It may be interesting to be able to change the Computer Icon.
But here, it seems to be the localized text that is being sought (shell32.dll.mui with Resource Hacker)

Only looked at with win10 1809, the following line is the problem, better to delete it, I believe.

Code: [Select]

RegWrite,HKLM,0x2,Tmp_Default\Software\Microsoft\Windows\CurrentVersion\Explorer\CLSID\{20D04FE0-3AEA-1069-A2D8-08002B30309D},,"@#$pSystemRoot#$p\system32\shell32.dll,-33010"

"@#$pSystemRoot#$p\system32\shell32.dll,-33010"   is still "Computer"
In relation to other keys It is probably best to change it to ("Computer" also):
"@%windir%\system32\windows.storage.dll,-9012"   

which gives for Win10 1809:

Code: [Select]

RegWrite,HKLM,0x2,Tmp_Software\Classes\CLSID\{20D04FE0-3AEA-1069-A2D8-08002B30309D},LocalizedString,"@%windir%\system32\windows.storage.dll,-9012"

@Lancelot :
@ChrisR already answered to your question. 

Registry is showing this on my rig :

hi,
Perhaps i don't understand the goal ... so i beg your pardon in advance

If the goal is to change the text under the icon ( not the icon ), you can try :
    $cle = join-path $tmp_soft_PS 'Classes\CLSID\{20D04FE0-3AEA-1069-A2D8-08002B30309D}'
       ($tmp_soft_PS is mirror of hklm\software winpe in my context !)
    $null = Set-ItemProperty $cle -name 'LocalizedString' -value '%computername% %userName%' -Type ExpandString
you can easy convert ...

In the picture i post in "microwinbuilder..." you can see this text under the icon "microwinpe system" for the system session  and "microwinpe administrator" for the adm session.
for me, the icon is set in the key "DefaultIcon"

Explorer (i don't for other shell) read the text which is two environment variables, expand them and display them.
Sorry if my reply is stupid in your context, i return to my bug.

noelblanc,

    the location at windows.storage.dll, --> Resource #9216 contains default string needed for computer.  It's the correct method to source the string.  but it is most definately easier to just add it manually.  I believe this is needed to display correctly for different languages though 

I believe this is needed to display correctly for different languages though 

Yes 

There was a bug on your update (you missed Call,TargetVersion,,4x I mentioned on reply 4) http://theoven.org/index.php?topic=2698.msg30584#msg30584  )
"My Computer - Name" plugin updated with fix + all info on current topic.

Sorry if my reply is stupid in your context, i return to my bug.

No.

ps: on my initial posts I thought string value or location changed, but as Chris wrote it did not, I was wrong.

*
Goal is changing default "This PC" to "Computer" localized.
your code is using a custom name with {Default} which also exists as an option on plugin and works fine as APT wrote.

*
To change the text under the icon there are 2 (maybe probably more) ways.

one of them is "LocalizedString" other is {Default} value. {Default} override LocalizedString.

Before Win10.... Explorer was expanding {Default} value if you add "@%SystemRoot%\system32\shell32.dll,-33010"
so to keep on safe side I had written the plugin to write to both "LocalizedString" and {Default}

with feedback by APT we now understand Explorer behavior changed and {Default} value not expanded.
In the past:
{Default} "@%SystemRoot%\system32\shell32.dll,-33010" --> show: Computer
today:
{Default} "@%SystemRoot%\system32\shell32.dll,-33010" --> show: @%SystemRoot%\system32\shell32.dll,-33010
(see APT picture at topic post http://theoven.org/index.php?topic=2698.msg30577#msg30577 )

We learn a new thing. 


*
Chris Comment with:
> It may be interesting to be able to change the Computer Icon.
is a response to RXTech post
> Most icons used for special folders (ThisPC icon for instance) are taken from imageres.dll
a side by side related subject.

**
Now I have to reset my windows 10 first time after 4 or 5 years since winbuilder screw up my registry badly during tests.... 

Hi guys

just confirming results of four options from plugin - My Computer - Name  v11



seems to do 'what is said on the box' 

regards APT

@Lancelot, thank you very much to be cool with me

may i also say i prefer see on my winpe screen "%computer% %username% than the word "computer" in the good language.
It's why i use the environment variables in localizedString which are more explicit for me.

just confirming results of four options from plugin - My Computer - Name  v11

Thanks for feedback APT, new version v15 on server with a new option.
(to fix some server troubles after my windows reset I had to update lot of versions ;))

btw,
"My Computer - Name" Plugin already have original plugin page. 
I do not spend time to open a topic for each plugin, still some already have....
Better check "Plugin Page" next time. 

Hi noelBlanc,

may i also say i prefer see on my winpe screen "%computer% %username% than the word "computer" in the good language.

Thanks for the picture, I just saw picture after updating plugin with a new option. It was 0 kb most of the day
I use:
%username% %computername%

yours in picture:
%computername% %username% %OS%

I am close. 

I like %username% alone, which shows a simple SYSTEM or Administrator serves good to keep which login I am on.

+
where did you change %computername% to MicroWinPe
Add something to environment variables ? or ?

+
Just to underline :
I use {Default} to add %username% which works fine.
{Default} only can not use localized string but fine with variables.

+
just a note:
we can not use localized info with another thing like variable, this did not work with LocalizedString
%username% @%SystemRoot%\system32\shell32.dll,-33010

(at least did not work on one of my tests...)

+
From picture I see "Localized String" Overrides {Default} at:
HKEY_Classes_ROOT\CLSID\{20D04FE0-3AEA-1069-A2D8-08002B30309D}

I use
HKEY_Current_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\CLSID\{20D04FE0-3AEA-1069-A2D8-08002B30309D}
here {Default} Overrides "Localized String" and Overrides HKEY_Classes_ROOT

with other words I use:

Code: [Select]

reg.exe Add "HKLM\Tmp_Default\Software\Microsoft\Windows\CurrentVersion\Explorer\CLSID\{20D04FE0-3AEA-1069-A2D8-08002B30309D}" /ve /t REG_EXPAND_SZ /d "%%username%% %%computername%%" /f

See you on next post...

@Lancelot, thank you very much to be cool with me

well, sorry on my side, previous posts we met in passing time sometimes bad.

Long story to short, there were some lazy or "I" people coming around time to time with fake id asking same things through years (eg. how to get wow64 work etc.),
 and I thought you were one of them ........


btw:
I see now you will be able to test with Citrix server on other topic, have fun. 

@Lancelot

thanks for the info re update to v15 of plugin

ps

"My Computer - Name" Plugin already have original plugin page.

I did search on forum and google, could only find a five year old reference mid post of
http://theoven.org/index.php?topic=851.msg10792#msg10792  around post 9
so assumed a new one would be preferable

Hi APT,

That topic is ~2014, at that times SE not include all plugins (still not) and a lot Gena Components plugins not tested with SE,
 there was "Share Plugin" method between projects,
  Chris had decided to add this plugin to SE Tweaks on that topic and things continue....

In reality, I still update and improve apinux 2013 plugin, compatible to all Gena & SE projects.

It will be better to keep plugin update info on plugin topic when possible, that is the reason I put "Plugin Page" weblinks to plugins.

I still update "Plugin Page" weblinks on new plugins, recently mostly new Bob.Omb and Prz42 plugins, to keep plugin related feedback on same topics when possible.

Anyway, I hope you like new "Custom Special" option. 
eg.
%username% APT