The Oven

Builder World => PEBakery => Topic started by: Bigbadmoshe on October 31, 2019, 03:10:33 PM

Title: PEBakery & Win10XPE - Wimlib Cleanup and reduce
Post by: Bigbadmoshe on October 31, 2019, 03:10:33 PM
I have had this issue for months.

I have tried with PEBakery versions nightly.1.0.1255 - nightly.1.0.1327

I have Tested on a completely clean basic extract of PEBakery & Win10XPE. Used a few different ISO Extracts.

Quote
<Errors>
- [1] Error in script [Create ISO] (Win10XPE\CreateISO.script)
[Error] If - Illegal characters in path. (If,ExistDir,%GTarget_Sys%\#9,ShellExecute,Hide,cmd.exe,"/C Dir /A:-D /B #$q%GTarget_Sys%\#9\*.*#$q >> #$q%TargetMui32File%#$q",%TempFolder%) (Line 233)
  |-> Referenced script [Check Target Sys Files] (Win10XPE\Features\CheckSysFiles.script)

<Warnings>
- [1] Warning in script [Build Core] (Win10XPE\Core.script)
[Warning] Echo - Wimlib Cleanup and reduce Winre.wim return : -1 (Else,Echo,"Wimlib Cleanup and reduce Winre.wim return : %ExitCode%",Warn) (Line 792)

- [2] Warnings in script [Create ISO] (Win10XPE\CreateISO.script)
[Warning] Echo - Build Stopped due to an Error. (Echo,"Build Stopped due to an Error.",Warn) (Line 369)
[Warning] Build stopped by error
Title: Re: PEBakery & Win10XPE - Wimlib Cleanup and reduce
Post by: Bigbadmoshe on October 31, 2019, 03:41:16 PM
Ran a Test with No compatibility options.

Quote
<Warnings>
- [1] Warning in script [Build Core] (Win10XPE\Core.script)
[Warning] Echo - Wimlib Cleanup and reduce Winre.wim return : -1 (Else,Echo,"Wimlib Cleanup and reduce Winre.wim return : %ExitCode%",Warn) (Line 792)

So it builds but its not being reduced (no cleanup)
Title: Re: PEBakery & Win10XPE - Wimlib Cleanup and reduce
Post by: APT on October 31, 2019, 07:13:31 PM
Hi Bigbadmoshe

testing with latest XPE distribution and PEBakery nightly and all compat options ticked, I'm not getting either of those problems

regards APT
Title: Re: PEBakery & Win10XPE - Wimlib Cleanup and reduce
Post by: Homes32 on October 31, 2019, 07:20:31 PM
The error pretty much says it. You have a illegal character in your path that
Quote
If,ExistDir,%GTarget_Sys%\#9
is testing for.
Windows doesn't allow the following chars to be a part of a file/folder name:
    < (less than)
    > (greater than)
    : (colon)
    " (double quote)
    / (forward slash)
    \ (backslash)
    | (vertical bar or pipe)
    ? (question mark)
    * (asterisk)

in your full log check the value of #9 right before the error.

 looking at the code from [Check Target Sys Files] (Win10XPE\Features\CheckSysFiles.script) it's most likely a stray pipe | in %FallBackLanguage% causing your trouble.
Title: Re: PEBakery & Win10XPE - Wimlib Cleanup and reduce
Post by: Bigbadmoshe on November 04, 2019, 03:59:53 PM
The error pretty much says it. You have a illegal character in your path that
Quote
If,ExistDir,%GTarget_Sys%\#9
is testing for.
Windows doesn't allow the following chars to be a part of a file/folder name:
    < (less than)
    > (greater than)
    : (colon)
    " (double quote)
    / (forward slash)
    \ (backslash)
    | (vertical bar or pipe)
    ? (question mark)
    * (asterisk)

in your full log check the value of #9 right before the error.

 looking at the code from [Check Target Sys Files] (Win10XPE\Features\CheckSysFiles.script) it's most likely a stray pipe | in %FallBackLanguage% causing your trouble.

I will take a look and see.

I have tested with a clean extract on the same computer and had same errors. Using VM i did not get this error.
Title: Re: PEBakery & Win10XPE - Wimlib Cleanup and reduce
Post by: Bigbadmoshe on November 05, 2019, 07:30:18 AM
The error pretty much says it. You have a illegal character in your path that
Quote
If,ExistDir,%GTarget_Sys%\#9
is testing for.
Windows doesn't allow the following chars to be a part of a file/folder name:
    < (less than)
    > (greater than)
    : (colon)
    " (double quote)
    / (forward slash)
    \ (backslash)
    | (vertical bar or pipe)
    ? (question mark)
    * (asterisk)

in your full log check the value of #9 right before the error.

 looking at the code from [Check Target Sys Files] (Win10XPE\Features\CheckSysFiles.script) it's most likely a stray pipe | in %FallBackLanguage% causing your trouble.

I no longer have this issue. Only

<Warnings>
- [1] Warning in script [Build Core] (Win10XPE\Core.script)
[Warning] Echo - Wimlib Cleanup and reduce Winre.wim return : -1 (Else,Echo,"Wimlib Cleanup and reduce Winre.wim return : %ExitCode%",Warn) (Line 792)