Topic: Search plugin ko-KR support  (Read 4829 times)

Search plugin ko-KR support
« on: October 11, 2015, 06:49:49 PM »

ied206

  • Chef
  • ***
  • Location: South Korea
  • Date Registered: Jan 2014
  • Posts: 257
When using Windows 10 K (Korean Version) as a source for Win10PESE, Search did not work in explorer.exe even if I checked Search.scipt.
While researching about Korean IME, I found out because korwbrkr.lex, korwbrkr.dll was missing, search was not working in PE made with ko-KR Windows.
This affects all of SE Projects (Win7PESE, Win8PESE, Win8.1SE, Win10PESE), as a result search was broken in either of them with ko-KR sources.

As a workaround, I added a piece of code into [Win8_FileCopy], [Win8.1_FileCopy], [Win10_FileCopy] in Search.script.

Code: [Select]
If,%DistLang%,Equal,ko-KR,Begin
Require_FileQ,korwbrkr.lex
Require_FileQ,korwbrkr.dll
End

With patched plugin, search works well with Win10PESE made with Windows 10 Pro K.
In theory, search should work in Win8PESE and Win8.1SE made with ko-KR source, too.

« Last Edit: October 15, 2015, 03:00:34 PM by ied206 »

Re: Search.script ko-KR support
« Reply #1 on: October 15, 2015, 01:08:22 PM »

ied206

  • Chef
  • ***
  • Location: South Korea
  • Date Registered: Jan 2014
  • Posts: 257
Version 8 of search plugin has ciritical typo in [Win8_Search_Registry] section, using End without Begin.
As a result, using version 8 of search plugin in Win8PESE caused 'Stack is empty', forcing to stop while building.

Code: [Select]
[Win8_Search_Registry]
RegWrite,HKLM,0x4,Tmp_Default\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced,Start_SearchFiles,0
RegWrite,HKLM,0x4,Tmp_Default\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced,Start_SearchPrograms,1
//-
ShellExecute,hide,%RegeditexeFolder%regedit.exe,"/s #$q%ProjectTemp%\Search\SearchClasses.reg#$q"
ShellExecute,hide,%RegeditexeFolder%regedit.exe,"/s #$q%ProjectTemp%\Search\WindowsSearchSoft.reg#$q"
ShellExecute,hide,%RegeditexeFolder%regedit.exe,"/s #$q%ProjectTemp%\Search\ContentIndex.reg#$q"
ShellExecute,hide,%RegeditexeFolder%regedit.exe,"/s #$q%ProjectTemp%\Search\WSearch.reg#$q"
ShellExecute,hide,%RegeditexeFolder%regedit.exe,"/s #$q%ProjectTemp%\Search\WSearchIdxPi.reg#$q"
End

Also, I noticed version 8 of this plugin has no support for Win7PESE, and figured out Win7PESE is still using version 6 of this plugin.
So I added Win7PESE compability back to search plugin, making this plugin universal for all SE projects.
(Code for Win7PESE compability was taken from version 7)


[Simple CHANGELOG]
Fixed 'End' Typo, and added  Win7PESE compability.
Tested on Win7PESE, Win8PESE, Win8.1SE, Win10PESE with ko-KR (Korean) sources.
« Last Edit: October 15, 2015, 03:00:13 PM by ied206 »

Re: Search plugin ko-KR support
« Reply #2 on: October 15, 2015, 09:24:19 PM »

ChrisR

  • XPE Baker
  • Grand Chef
  • *****
  • Date Registered: Mar 2011
  • Posts: 3494
Great to have the Korean Support now and to have the same plugins between projects  :great:
Thanks a lot, it is on server  :thumbsup:

Re: Search plugin ko-KR support
« Reply #3 on: October 16, 2015, 04:50:24 AM »

hassan.ogaibi

  • Apprentice
  • *
  • Date Registered: Dec 2014
  • Posts: 5
Is this means  I can fix "searching problem" by adding those two files?

Re: Search plugin ko-KR support
« Reply #4 on: October 16, 2015, 03:15:00 PM »

ied206

  • Chef
  • ***
  • Location: South Korea
  • Date Registered: Jan 2014
  • Posts: 257
hassan.ogaibi, if you were using Korean (ko-KR) sources to build Win10PESE, this patch will work for you.
Otherwise, it would not work since Windows has different dependency following its locale.

Re: Search plugin ko-KR support
« Reply #5 on: October 16, 2015, 05:35:39 PM »

Lancelot

  • Gena Baker
  • Grand Chef
  • *****
  • Date Registered: Sep 2010
  • Posts: 10350
hassan.ogaibi

Follow forum rules, http://theoven.org/index.php?action=rules
 NEVER increase size of text to take attention again.
  People can read, and respond if interested, when they free time.
    First and Last warning....  :horse:
« Last Edit: October 16, 2015, 05:42:50 PM by Lancelot »

Re: Search plugin ko-KR support
« Reply #6 on: October 16, 2015, 09:04:19 PM »

mynhow

  • Jr. Chef
  • **
  • Date Registered: Oct 2015
  • Posts: 43
Hi.

Is someone able to search on the Search box? Because searching is not working for me .

I created a full build using the latest version of Winbuilder and Windows 10 64bit en-US downloaded from Tech Bench with search.script selected, but it is not working.

I also created a script to start the WSearch service on boot, but still not working.

A small question: Does it need 7-zip to work?

I wonder if someone could help me, please.

Thanks.

Re: Search plugin ko-KR support
« Reply #7 on: October 17, 2015, 04:54:25 PM »

ied206

  • Chef
  • ***
  • Location: South Korea
  • Date Registered: Jan 2014
  • Posts: 257
mynhow, which locale PE has in your built PE? (Or, host's locale)
Since SE Projects automatically import locale and string format from Host OS by default, it can have different locale compared to source.
This plugin can deal with Thai, Korean, Japanese, Chinese locale and Western Europe locales.
Can you check it out?

Answer for a small question: No, it doesn't.
SE Projects has own 7z in Projects folder, the script does not have foreign dependency.
It can extract 7z file on its own.

Re: Search plugin ko-KR support
« Reply #8 on: October 17, 2015, 06:48:41 PM »

mynhow

  • Jr. Chef
  • **
  • Date Registered: Oct 2015
  • Posts: 43
ied206, my build is en-US. My local host and the iso that use to make the build are en-US too. Just the timezone is different. Can this plugin deal with en_US right?

Could you tell me if you can search in your build, please?

Thanks.

 

Powered by EzPortal